backrest: init at 1.5.0 #342141
Merged
backrest: init at 1.5.0 #342141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: maintainer-list (update)
NixOSInfra
added
the
12. first-time contribution
interdependence
force-pushed
the
backrest
branch
2 times, most recently
from
5f7c8a3
to
9a40348
Compare
stv0g
suggested changes
Sep 15, 2024
pkgs/by-name/ba/backrest/package.nix
Outdated
| export HOME=$(pwd) | ||
| ''; | ||
|
|
||
| meta = with lib; { |
There was a problem hiding this comment.
Please try to avoid using with lib here as it pulls in a large scope.
There was a problem hiding this comment.
Okay I fixed that.
interdependence
force-pushed
the
backrest
branch
from
9a40348
to
aa71a1a
Compare
stv0g
approved these changes
Sep 15, 2024
ofborg
bot
added
8.has: package (new)
wegank
added
the
12.approvals: 1
Bot-wxt1221
reviewed
Sep 19, 2024
pkgs/by-name/ba/backrest/package.nix
Outdated
| src = fetchFromGitHub { | ||
| owner = "garethgeorge"; | ||
| repo = "backrest"; | ||
| rev = "v${version}"; |
There was a problem hiding this comment.
Suggested change
| rev = "v${version}"; | |
| rev = "refs/tags/v${version}"; |
pkgs/by-name/ba/backrest/package.nix
Outdated
Comment on lines
63
to
67
| platforms = [ | ||
| "x86_64-linux" | ||
| "aarch64-linux" | ||
| "x86_64-darwin" | ||
| "aarch64-darwin" |
There was a problem hiding this comment.
Suggested change
| platforms = [ | |
| "x86_64-linux" | |
| "aarch64-linux" | |
| "x86_64-darwin" | |
| "aarch64-darwin" | |
| platforms = lib.platforms.unix; |
interdependence
force-pushed
the
backrest
branch
from
aa71a1a
to
76fbeed
Compare
wegank
removed
the
12.approvals: 1
stv0g
approved these changes
Sep 20, 2024
Aleksanaa
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add Backrest: A web-accessible backup solution built on top of restic.
Closes #312298 @stv0g
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.